Base: Update Syrian Flag emoji #25588
Conversation
github-actions
bot
added
the
👀 pr-needs-review
There was a problem hiding this comment.
From a technical pow it should be 10 px high and at most 10 px wide to follow the format of our other emoji. It should also be optimized.
I've sent a few lines to @timschumi about the political aspect of the change and is very happy I don't have to make any decision on this one.
|
Didn't mean to make this a political commit (I know flags are inherently political but I thought of it more from the fact that I just like flags.) I was unaware of the size constraint so if it's easier I can submit another pull request. In terms of optimization, the file is just an extra 21 bytes long (at least it should be. I submitted it through the github web interface, not the command line, so I don't know if github added some exif data.) But it should all be optimized. |
|
On the topic of the file size, it should be sufficient to run the file through Aside from the technical aspects, it seems that there is no clear consensus (yet) on whether the proposed flag is officially recognized and whether fonts should start updating the representation. For example, similar discussions are currently happening with Google Noto and Twemoji. Please do note that Wikipedia is not a reliable primary source and that, despite increased usage especially in the last few weeks (even including various government institutions and being regarded as "de facto"), this does not automatically imply that the choice or design is final. As documented by Emojipedia for precedent and as recommended by Unicode (relevant excerpt to follow), we will keep this PR open until the situation has become more clear.
|
timschumi
added
the
⛔️ pr-is-blocked
I had to skip adding North Korean provincial flags because the only official flags I could find was the South Korean ones for the northern provinces because they doesn't seem to recognize the north or something like that. I wanted to do it because I like flags but it was a bit to political for being added, iirc. But you are not alone in liking flags, we do 168 Tag Sequence Flags, it's not RGI but it's allowed in Unicode so we do it: serenity/Base/home/anon/Documents/emoji-serenity.txt Lines 84 to 251 in 9a5d25c If you want to have fun with flags and don't mind it being more or less compatible with only Serenity you could add provincial flags for Canada or Brazil for example, you can find all the codes at https://emojipedia.org/emoji-tag-sequence#list |
|
That sounds fun! Should a pull request also add the emoji name and codepoints to the anon/Documents/emoji-serenity.txt file? |
|
Closed this PR on accident, don't believe I can reopen it since I deleted the original repository. See #25644 for current discussion. |
Syria just had a flag change, thought it should be updated.