2023-07-03 Python requirements files + Bookworm - master branch #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying cause of the problem reported in SensorsIot#660 is the Python requirements files containing pins for (almost) every line item. I appreciate that pinning is what happens by default when requirements files are generated but some of the pinned versions which might have been appropriate for Bullseye when the files were generated will not actually install on Bookworm. This Pull Request removes pins from every line item in each requirements file. In other words, the defaults will become the latest and greatest for each system (Buster or Bullseye or Bookworm). I have tested this on Bullseye and Bookworm (but not Buster), and only to the extent of confirming that each listed package gets installed and the menu doesn't chuck up any complaints. The test systems were built with [PiBuilder](https://github.com/Paraphraser/PiBuilder). **IF** we encounter a problem which needs to be solved by pinning a package to a specific version, we will have to sort out how to do that across OS releases. Fixes: SensorsIot#660 Signed-off-by: Phill Kelley <[email protected]>
Slyke
approved these changes
Sep 23, 2023
Slyke
approved these changes
Sep 23, 2023
Paraphraser
added a commit
to Paraphraser/PiBuilder
that referenced
this pull request
Oct 6, 2023
[PR 723](SensorsIot/IOTstack#723) removed pins from Python requirements files so the PiBuilder "fix" to do that using `sed` is no longer required. Removed. Signed-off-by: Phill Kelley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying cause of the problem reported in #660 is the Python requirements files containing pins for (almost) every line item.
I appreciate that pinning is what happens by default when requirements files are generated but some of the pinned versions which might have been appropriate for Bullseye when the files were generated will not actually install on Bookworm.
This Pull Request removes pins from every line item in each requirements file. In other words, the defaults will become the latest and greatest for each system (Buster or Bullseye or Bookworm).
I have tested this on Bullseye and Bookworm (but not Buster), and only to the extent of confirming that each listed package gets installed and the menu doesn't chuck up any complaints. The test systems were built with PiBuilder.
IF we encounter a problem which needs to be solved by pinning a package to a specific version, we will have to sort out how to do that across OS releases.
Fixes: #660