[placeholder] allow for omission of certain attributes on placeholder clone

[tony-kerz]

if placeholder clone includes data-reactid attributes, react will throw:

Uncaught Error: Invariant Violation: ReactMount: Two valid but unequal nodes with the same `data-reactid`: .0.0.0.0

this fix allows for a call syntax like below which will omit data-reactid attributes and skirt error:

  componentDidMount() {
    console.log('menu: cdm')
    $(React.findDOMNode(this)).visibility(
      {
        type: 'fixed',
        omitPlaceholderAttrs: 'data-reactid'
      }
    )
  }

[jlukic]

I understand, let me consider the best way to handle this. I think this is a little 'brute force'.

All PR changes need to be merged into main repo semantic-org/semantic-ui, this repo is automatically generated

[tony-kerz]

thanks jack,

yeah, i'm kind of an intermediate front-end brute,
so i'm down with any solution you approve of that skirts that issue.

best,
tony.

On Sun, Jul 26, 2015 at 1:01 PM, Jack Lukic [email protected]
wrote:

I understand, let me consider the best way to handle this. I think this is
a little 'brute force'

—
Reply to this email directly or view it on GitHub
#1 (comment)
.

[jwdomingo]

@tony-kerz, if this is still relevant to you, I just ran into problem while using the Dropdown module. I was able to prevent it by adding data-text attributes to each item in the dropdown menu. This makes it so that the elements within the tag are not cloned but rather a new element is mounted as the placeholder so React makes a new ID. Hope that helps!

Check out Specifying Different Text & Hidden Input Values

[eyalw]

Hey, you think this will be solved with React 15 removing data-reactId from the DOM?