Skip to content

[deploy site] fixing bug 2402, detectify link removal #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Aug 1, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

fixing bug 2402, detectify link removal

Description

fixing bug 2402, detectify link removal. removed the link, mentioned whole name of company, and we want user to directly go see the blog which is on their website. So that solves the purpose.

Motivation and Context

Bug 2404

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Remove hyperlink from Detectify reference in Grid documentation

  • Replace linked text with plain text "Detectify Labs"

  • Update formatting and punctuation across multiple language versions


Diagram Walkthrough

flowchart LR
  A["Hyperlinked Detectify reference"] --> B["Plain text Detectify Labs"]
  B --> C["Updated across 4 language versions"]
Loading

File Walkthrough

Relevant files
Documentation
getting_started.en.md
Remove Detectify hyperlink in English docs                             

website_and_docs/content/documentation/grid/getting_started.en.md

  • Remove hyperlink from "Detectify" text
  • Change to plain text "Detectify Labs"
  • Add period at end of sentence
+2/-3     
getting_started.ja.md
Remove Detectify hyperlink in Japanese docs                           

website_and_docs/content/documentation/grid/getting_started.ja.md

  • Remove hyperlink from Detectify reference
  • Change to plain text "Detectify Labs,"
+1/-1     
getting_started.pt-br.md
Remove Detectify hyperlink in Portuguese docs                       

website_and_docs/content/documentation/grid/getting_started.pt-br.md

  • Remove hyperlink from Detectify reference
  • Change to plain text "Detectify Labs,"
+1/-1     
getting_started.zh-cn.md
Remove Detectify hyperlink in Chinese docs                             

website_and_docs/content/documentation/grid/getting_started.zh-cn.md

  • Remove hyperlink from Detectify reference
  • Change to plain text "Detectify Labs,"
+1/-1     

@pallavigitwork pallavigitwork self-assigned this Aug 1, 2025
Copy link

netlify bot commented Aug 1, 2025

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 156d112

Copy link
Contributor

qodo-merge-pro bot commented Aug 1, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Formatting Issue

The sentence structure is awkward with the colon placement. The text reads "See this blog post on Detectify Labs, which gives a good overview of how a publicly exposed Grid could be misused:" followed by the link on the next line, creating an unnatural break.

See this blog post on Detectify Labs, which gives a good overview of how a publicly exposed Grid could be misused:
[Don't Leave your Grid Wide Open](//labs.detectify.com/2017/10/06/guest-blog-dont-leave-your-grid-wide-open/).
Grammar Issue

The comma placement after "Detectify Labs," appears incorrect in Japanese context and creates awkward sentence flow when combined with the following text.

Detectify Labs, のブログで公開されてしまった Grid が
どのように悪用されるかを紹介しています: [Don't Leave your Grid Wide Open](//labs.detectify.com/2017/10/06/guest-blog-dont-leave-your-grid-wide-open/)

Copy link
Contributor

qodo-merge-pro bot commented Aug 1, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Remove unnecessary comma after company name

Remove the unnecessary comma after "Detectify Labs" to improve readability. The
comma creates an awkward pause in the Japanese sentence structure.

website_and_docs/content/documentation/grid/getting_started.ja.md [307]

-Detectify Labs, のブログで公開されてしまった Grid が
+Detectify Labs のブログで公開されてしまった Grid が
  • Apply / Chat
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies that the comma after Detectify Labs is grammatically incorrect in the Japanese sentence, and removing it improves readability.

Low
  • More

@pallavigitwork pallavigitwork merged commit 0b29bc6 into SeleniumHQ:trunk Aug 1, 2025
3 checks passed
@pallavigitwork pallavigitwork deleted the Fix2402-pal branch August 1, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant