-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[js][bidi] Add Emulation module support #16179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨ |
User description
🔗 Related Issues
💥 What does this PR do?
Adds Emulation module support as per BiDi spec
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Add BiDi Emulation module with geolocation override support
Implement GeolocationCoordinates class with validation and fluent API
Add comprehensive test coverage for browsing and user contexts
Update build configuration to include emulation module
Diagram Walkthrough
File Walkthrough
emulation.js
Core Emulation module implementation
javascript/selenium-webdriver/bidi/emulation/emulation.js
setGeolocationOverride
method for coordinates and errorstates
geolocationCoordinates.js
GeolocationCoordinates class with validation
javascript/selenium-webdriver/bidi/emulation/geolocationCoordinates.js
speed
emulation_test.js
Comprehensive test coverage for Emulation
javascript/selenium-webdriver/test/bidi/emulation_test.js
BUILD.bazel
Build configuration update
javascript/selenium-webdriver/BUILD.bazel
bidi/emulation/*.js
pattern to js_library sources