-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[js] Add extended and symbolic macOS/ChromeDriver key representations #15957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
[js] Add extended and symbolic macOS/ChromeDriver key representations #15957
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
🔗 Related Issues
fixes #15945
💥 What does this PR do?
This pull request adds support for extended macOS/ChromeDriver keys and symbolic macOS keys in the
webdriver.Key
object withinjavascript/webdriver/key.js
. These changes expand the range of key codes available for macOS-specific functionality.Enhancements to macOS key support:
javascript/webdriver/key.js
: Added extended macOS/ChromeDriver keys (RIGHT_SHIFT
,RIGHT_CONTROL
,RIGHT_ALT
,RIGHT_COMMAND
) with their respective Unicode values.javascript/webdriver/key.js
: Introduced symbolic macOS keys (OPTIONS
,FUNCTION
) with placeholder Unicode values, pending verification with the WebDriver specification.🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Add extended macOS/ChromeDriver key representations (RIGHT_SHIFT, RIGHT_CONTROL, RIGHT_ALT, RIGHT_COMMAND)
Introduce symbolic macOS keys (OPTIONS, FUNCTION) with placeholder Unicode values
Expand key code support for macOS-specific functionality
Changes walkthrough 📝
key.js
Extended macOS key support
javascript/webdriver/key.js