Skip to content

Conversation

RenderMichael
Copy link
Contributor

Implements the Permissions WebDriver BiDi module.

Reliant on #15420

Motivation and Context

Fixes #15329

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@RenderMichael
Copy link
Contributor Author

Aside from providing the Permissions module, this PR also provides a PermissionsBiDi which enables a "BiDi + permissions extension" built-in.

This fulfills the ask in the issue to do:

var permissions = await driver.AsBiDiPermissionsAsync(); 

However, anyone can extend the BiDi type and add the PermissionsModule + any other extensions they would like.


namespace OpenQA.Selenium.BiDi.Extensions.Permissions;

public class PermissionsBiDi : BiDi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not derive from BiDi.

Copy link
Member

@nvborisenko nvborisenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this one we don't want conceptually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: [dotnet] Provide a possibility to implement BiDi Permissions module
2 participants