Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][BiDi]: enable Edge tests for RemoteWebDriverBiDiTest #15412

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Mar 13, 2025

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Motivation and Context

enable Edge tests for RemoteWebDriverBiDiTest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Tests, Enhancement


Description

  • Enabled Edge browser support for RemoteWebDriverBiDiTest.

  • Removed @NotYetImplemented(EDGE) annotations from relevant test methods.

  • Updated Bazel configuration to include Edge in firefox-chromium-only-large-tests.

  • Adjusted test suite naming and exclusions to reflect Edge support.


Changes walkthrough 📝

Relevant files
Tests
RemoteWebDriverBiDiTest.java
Enable Edge browser support in BiDi tests                               

java/test/org/openqa/selenium/grid/router/RemoteWebDriverBiDiTest.java

  • Removed @NotYetImplemented(EDGE) annotations from three test methods.
  • Ensured Edge browser compatibility for BiDi session creation, log
    listening, and URL navigation tests.
  • +0/-3     
    Configuration changes
    BUILD.bazel
    Update Bazel configuration for Edge browser support           

    java/test/org/openqa/selenium/grid/router/BUILD.bazel

  • Renamed FIREFOX_CHROME_ONLY_LARGE_TESTS to
    FIREFOX_CHROMIUM_ONLY_LARGE_TESTS.
  • Added Edge browser to firefox-chromium-only-large-tests.
  • Updated exclusions in medium-tests to reflect the new test suite name.
  • +5/-4     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Mar 13, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant