Wrappers s2i conda image #6896
Draft
Wrappers s2i conda image #6896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtaskow
commented
Oct 23, 2025
| @@ -0,0 +1 @@ | |||
| python 3.8.10 | |||
tyndria
reviewed
Oct 27, 2025
| # source: tensorflow/core/framework/resource_handle.proto | ||
| # Protobuf Python Version: 6.31.1 |
Contributor
There was a problem hiding this comment.
@vtaskow this changes were introduced after you builе python package, right?
I've recently did the same, and I've noticed I had a lower Protobuf Python version in such automatically updated files.
Is it a problem? Does it mean we haven't pinned this version in our local environments? Should we pin it somehow?
vtaskow
force-pushed
the
wrappers-s2i-conda-image
branch
from
5d06114 to
c388799
Compare
Contributor
|
PR with |
…- Dockerfiles build, make test works
…ails to resolve because seldon-core package requires >= 2.3.4, same as thinc(unclear where this comes from)
…e wrappers folder to be run successfully
…pass, dockerfile builds
… but raises image size from 370 to 415 MB
… patched version of pip
…hin poetry with patched version of pip due to High cve
…uf from 4.X to 5.X - e2e tests are failing due to depending on MLServer 1.7.X depending on higher protobuf version
vtaskow
force-pushed
the
wrappers-s2i-conda-image
branch
from
a87a2ad to
8cdb56a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Issues
Motivation
What
Summary of changes
Checklist
Testing