Update for GNOME 44 #235
Merged
Update for GNOME 44 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SeaDve Could this get a review? The Flathub stable release causes undesired "checkerboard" video frames at the start of recordings which get especially annoying when they're displayed as video thumbnails on messaging platforms |
|
Thank you for the PR, and also sorry for the really late update |
SeaDve
requested changes
Apr 27, 2023
SeaDve
reviewed
Apr 27, 2023
GNOME Builder 44 places the directory at the root of the project
SeaDve
reviewed
Apr 28, 2023
SeaDve
reviewed
Apr 29, 2023
SeaDve
approved these changes
Apr 30, 2023
Gtk.FileDialog allows selecting from directories that are not explicitly permitted within the Flatpak manifest, and grants the app permission upon a user doing so. Therefore, `is_accessible` and the related dialog are no longer relevant. Do note that if not explicitly allowed, the directory will show as a not-so-pretty sandboxed path.
|
Kooha is now having issues recording videos on both the main branch and this branch. Looking into the cause right now. Related issue: #236 |
|
We could also have this merge first, then maybe do it in a separate PR |
|
That works too 🙂 |
|
Merged. Thanks again for the PR! |
|
Recording issues seem to have fixed themselves at some point, on Fedora 38 at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated gtk-rs crates to latest versions & bumped Flatpak runtime to 44
Seems updating the runtime to 44 had the side effect of removing the checkerboard pattern from the start of my recordings 🙂