Add AppArmor 4 config #402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kurt-von-Laven friendly ping |
|
@mwarres friendly ping |
|
I emailed @Kurt-von-Laven on 2025-01-04. I'll relay any of those updates here. |
|
I just tested the code in this PR and it works |
twelho
added a commit
to supernetes/supernetes
that referenced
this pull request
Sep 6, 2025
Upgrading to `ubuntu-24.04` is blocked by this Action due to [AppArmor changes](ScribeMD/rootless-docker#401). The [PR for fixing this](ScribeMD/rootless-docker#402) is up, but upstream is dormant. However, Renovate will try the `ubuntu-24.04` upgrade immediately, so let's switch to a pinned version of the Action that carries the fix for now. Signed-off-by: Dennis Marttinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are these changes?
This change resolves #401 by adding an AppArmor profile for rootlesskit on runners using AppArmor 4.
Why are these changes being made?
These changes are required to run ScribeMD/rootless-docker on
ubuntu-24.04.Notes:
ubuntu-22.04(which uses AppArmor 3), so I've configured this change to only apply the config on platforms using AppArmor 4 (steps.apparmor.outputs.ABI4_VERSION != '').