deploy: dashboard labels and show_labels setting to production#24
Merged
Conversation
- Re-import getCredentials from @screenly/edge-apps - Remove local getCredentials override added for demo - Remove debug console.log - Remove dashboard_id fallback, use content_id only
Sync with Dev
* feat: add show_labels setting to toggle chart and gauge labels - Add `show_labels` boolean setting to screenly.yml and screenly_qc.yml - Thread `showLabels` flag through main.ts, renderDashboard, renderReport, renderComponent, renderChart, and renderGauge - Extract src/render/report.ts with all report-specific rendering logic to keep index.ts within the max-lines lint limit - Add dashboard-labels screenshot tests at 1920x1080 and 1080x1920 - Refactor takeScreenshot to inline networkidle wait and extract mockCredentials, setupDashboardRoutes, and setupReportRoutes helpers * fix: address Copilot review comments - Add ReportResult to top-level import in index.ts - Replace inline import type with ReportResult in renderReport signature - Add explicit DashboardMetadataComponent type annotation to meta in renderReportTableCard - Add report-labels screenshot tests at 1920x1080 and 1080x1920
salmanfarisvp
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chartjs-plugin-datalabelsMetriccomponent type support with container-relative responsive font sizingRelated Pull Requests