Repository navigation
chore: update icon path to consolidated icons directory - #3
Open
nicomiguelino wants to merge 2 commits into
Open
nicomiguelino wants to merge 2 commits into
nicomiguelino wants to merge 2 commits into
Conversation
Contributor
|
Heads up: this PR currently has merge conflicts with Flagged by an automated PR-hygiene sweep — no action needed beyond the rebase, and no reply expected. |
salmanfarisvp
approved these changes
Oct 27, 2026
salmanfarisvp
marked this pull request as ready for review
October 27, 2026 13:16
There was a problem hiding this comment.
🔵 Needs a closer look
Restore screenly_qc.yml and update its icon path to prevent loss of the QC manifest.
No open issues 🎉
What changed in this PR
Updates Screenly manifest icon paths to use the consolidated Playground icons directory. The QC manifest is deleted instead of being updated, which conflicts with the pull request’s stated intent.
Changes:
- Updates
screenly.ymlto reference the consolidated icon URL. - Deletes
screenly_qc.yml; it should be restored with only its icon URL changed.
| File | Description |
|---|---|
screenly.yml |
Points the production manifest icon to the consolidated icons directory. |
screenly_qc.yml |
Deleted instead of being retained and updated with the consolidated icon URL. |
Review effort: Lite
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iconfield inscreenly.ymlandscreenly_qc.ymlto point to the new consolidated icons directory.Depends on Screenly/Playground#875.