chore: clean up Claude rules after Edge App migration#881
Open
nicomiguelino wants to merge 6 commits into
Open
chore: clean up Claude rules after Edge App migration#881nicomiguelino wants to merge 6 commits into
nicomiguelino wants to merge 6 commits into
Conversation
- Remove stale example apps and broken local paths in .claude/CLAUDE.md and the create-an-edge-app skill now that most Edge Apps live in standalone repos - Point reference-app links to their new standalone repos - Encourage maintainers to create new Edge Apps in standalone repos rather than this monorepo
|
Failed to generate code suggestions for PR |
|
Failed to generate code suggestions for PR |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Claude/Edge App authoring guidance to reflect that most Screenly Edge Apps have moved out of this monorepo into standalone repositories, and refreshes reference links accordingly.
Changes:
- Encourage maintainers to create new Edge Apps in standalone Screenly org repos instead of
edge-apps/in this monorepo. - Replace local
edge-apps/<app>/references with links to the corresponding standalone GitHub repositories. - Clarify that
edge-apps/now primarily contains the remaining unmigrated apps plus shared assets.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.claude/skills/create-an-edge-app/SKILL.md |
Updates Edge App creation guidance and swaps local reference-app paths for standalone repo links. |
.claude/rules/edge-apps.md |
Adds maintainer guidance to prefer standalone repos when creating new Edge Apps. |
.claude/CLAUDE.md |
Updates repo-level description to reflect Edge App migration to standalone repositories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Remove edge-apps/.bun-create/ now that maintainers are encouraged to create new Edge Apps in standalone repos - Update README.md, edge-apps/README.md, and the create-an-edge-app skill to scaffold from a reference app instead of bun create - Drop the now-dead .bun-create exclusion in edge-app-checks.yml
- Address Copilot review feedback: the plain HTML/CSS/JS scaffold step now only applies if the app stays in this monorepo
- Fix mdc:https:/ single-slash links in the Players section - Fix grammar: "allows to you to deploy" -> "allows you to deploy"
- Note edge-apps/ also holds redirect stubs for migrated apps, not just unmigrated ones - Say "most" instead of implying all Edge Apps have migrated - Point to edge-apps/README.md as creation guidance, not a scaffolding command (bun-create is gone)
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/CLAUDE.mdand thecreate-an-edge-appskill now that most Edge Apps live in standalone repos