Stricter array summary in CML output #6743
Conversation
- Add `checksum` to _DimensionalMetadata xml. - New `masked_count` attr added to cube and _DimensionalMetadata xml.
There was a problem hiding this comment.
@ukmo-ccbunney Lookin' good.
Just some initial comments to consider 👍
|
|
||
|
|
||
| def array_checksum(data: np.typing.ArrayLike) -> str: | ||
| """Calculate a checksum for a numpy array.""" |
There was a problem hiding this comment.
@ukmo-ccbunney Minor, but perhaps mention the type of checksum being performed?
I guess you also need to add the usual numpydoc docstring for parameters et al
| if hasattr(data, "to_xml_attr"): | ||
| result = data._values.to_xml_attr() | ||
| else: | ||
| result = iris.util.format_array(data) |
There was a problem hiding this comment.
@ukmo-ccbunney Should we consider deprecating format_array now?
Don't think it's used anywhere else and I guess we're now dropping use of it ourselves.
There was a problem hiding this comment.
I suddenly realised that the changes I was making would affect the the cube.xml() function which is part of the public API. Therefore I'll need to keep this for now (and maybe add a deprecation warning to cube.xml) to keep it working as-is.
| if np.ma.isMaskedArray(self._values): | ||
| element.setAttribute( | ||
| "masked_count", str(np.count_nonzero(self._values.mask)) | ||
| ) |
There was a problem hiding this comment.
@ukmo-ccbunney How aligned with the Cube XML attributes should we be here?
i.e., are state (for lazy payload) and masked_order applicable here too?
github-project-automation
bot
moved this from 🚀 In Progress
to 👀 In Review
in 🦌 Iris 3.14
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6743 +/- ##
==========================================
- Coverage 90.29% 89.93% -0.36%
==========================================
Files 91 91
Lines 24475 24597 +122
Branches 4571 4596 +25
==========================================
+ Hits 22100 22122 +22
- Misses 1607 1702 +95
- Partials 768 773 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
🚀 Pull Request
Closes: #6244
Description
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: