-
Notifications
You must be signed in to change notification settings - Fork 296
Created documentation for UX changes #6595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6595 +/- ##
==========================================
+ Coverage 89.89% 90.00% +0.11%
==========================================
Files 90 91 +1
Lines 24138 24447 +309
Branches 4492 4567 +75
==========================================
+ Hits 21699 22004 +305
+ Misses 1679 1676 -3
- Partials 760 767 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could I suggest referencing this in the new Iris Philosophy page?
iris/docs/src/userguide/iris_philosophy.rst
Lines 1 to 5 in deaaab9
.. _iris-philosophy: | |
**************** | |
Iris' Philosophy | |
**************** |
I don't know if it's possible to literally include some of the text from user_experience/index.rst
but that would be good if we could.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I.e. via some sort of directive so that changing the text in 1 place changes both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, having finished my review, which includes suggesting that minutes remain within GitHub. In that situation I think the content you are introducing would make an ideal addition to the Philosophy page, rather than adding any new pages/sections.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We said we wouldn't mess with the Philosophy page, but I think adding a reference like what was originally suggested is still relevant.
The single directive approach seems possible using MyST substitutions, albeit a bit round the houses. I can't find a way to do it via sphinx though, so I'll do it manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Granted, we should definitely be more public with minutes from meetings.
But minuting stuff in our documentation would be quite a departure from the norm. I would prefer that the documentation remain a 'user manual'; this means that wherever possible it is our official, unambiguous word, with no speculation/conversation.
GitHub is the ideal place for looser, less curated conversation. I would like to see more items like #5165 (comment) on our repo; this seems to be in a similar vein. Note this comment:
Note this issue is not intended as a debate, hence why it is not posted as a discussion. The below conversations took place in real time, with a group deliberately sized to aid decision making.
As the above implies, the default should probably be Discussions, not Issues. We could perhaps create a new discussions category for minutes, if this is something we aim to do more of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that might simplify things by making this a single page, rather than a section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm happy with that. Especially since there's already a UX discussion, the minutes could be added there, or linked at least.
* It might also be that Iris' user base is largely Met Office employees, who would rely on | ||
support and Viva Engage. We *DO NOT* think that we should put more focus onto Met Office | ||
employees, as that would skew the balance and dissuade further users from joining us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am comfortable sharing things like this, but it needs to make sense to all readers. Phrases like UK Met Office
and internal message boards
We do currently have the Community tab, which includes valuable documentation for xarray and | ||
pandas documentation. This is hard to find however, and misses links for things such as | ||
GeoVista and ncdata. We think this should be more immediate, or less buried. We also wonder | ||
if we should sell Iris as both a complete product *and a toolbox*, for using with xarray. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was supposed to be "a tool in a toolbox"
..note :: | ||
If you have any thoughts or comments on either the user experience of Iris, or on this page, | ||
please create a GitHub discussion, or comment in an existing one! We'd love to hear from you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..note :: | |
If you have any thoughts or comments on either the user experience of Iris, or on this page, | |
please create a GitHub discussion, or comment in an existing one! We'd love to hear from you! | |
.. note:: | |
If you have any thoughts or comments on either the user experience of Iris, or on this page, | |
please create a GitHub discussion, or comment in an existing one! We'd love to hear from you! |
|
||
Below are some potential topics to guide future discussions on the Iris user experience. | ||
|
||
..note :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..note :: | |
.. note:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, having finished my review, which includes suggesting that minutes remain within GitHub. In that situation I think the content you are introducing would make an ideal addition to the Philosophy page, rather than adding any new pages/sections.
What do you think?
I agree with most comments here, the minutes page I had forseen being a bit of a mess anyway, and putting it as a discussion seems wise. Adding the discussion guide to Philosophy feels a little crammed in. I could happily be vetoed, my feelings aren't strong, but it feels a bit like it's not so much a philosophy as it is guiding a process. The philosophy would be "we're having regular meetings, because". |
Yes I see your point, let's not mess with the Philosophy page |
🚀 Pull Request
Related #4799
Closes #6498
Left to do:
Add mention of the cultural changes we wish to seeMinutes removed from PRDouble check the minutes make senseMinutes removed from PR