Skip to content

Various ruff rule compliance (W, CPY, ISC, AIR) #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Various ruff rule compliance (W, CPY, ISC, AIR) #5667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afc3c11
fix pycodestyle W
tkknight Dec 30, 2023
c160c55
fix for ruff: flake8-copyright (CPY)
tkknight Dec 30, 2023
c9a23a5
ruff, no fix needed: flake8-implicit-str-concat (ISC)
tkknight Dec 30, 2023
4eff6fa
ruff, no fix needed: Airflow (AIR)
tkknight Dec 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ lint.ignore = [
# pycodestyle (E, W)
# https://docs.astral.sh/ruff/rules/#pycodestyle-e-w
"E",
"W",

# mccabe (C90)
# https://docs.astral.sh/ruff/rules/#mccabe-c90
Expand Down Expand Up @@ -71,10 +70,6 @@ lint.ignore = [
# https://docs.astral.sh/ruff/rules/#flake8-builtins-a
"A",

# flake8-copyright (CPY)
# https://docs.astral.sh/ruff/rules/#flake8-copyright-cpy
"CPY",

# flake8-comprehensions (C4)
# https://docs.astral.sh/ruff/rules/#flake8-comprehensions-c4
"C4",
Expand All @@ -91,10 +86,6 @@ lint.ignore = [
# https://docs.astral.sh/ruff/rules/#flake8-future-annotations-fa
"FA",

# flake8-implicit-str-concat (ISC)
# https://docs.astral.sh/ruff/rules/#flake8-implicit-str-concat-isc
"ISC",

# flake8-logging-format (G)
# https://docs.astral.sh/ruff/rules/#flake8-logging-format-g
"G",
Expand Down Expand Up @@ -187,10 +178,6 @@ lint.ignore = [
# https://docs.astral.sh/ruff/rules/#flynt-fly
"FLY",

# Airflow (AIR)
# https://docs.astral.sh/ruff/rules/#airflow-air
"AIR",

# Perflint (PERF)
# https://docs.astral.sh/ruff/rules/#perflint-perf
"PERF",
Expand Down
4 changes: 2 additions & 2 deletions benchmarks/bm_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,8 @@ def _gh_create_reports(commit_sha: str, results_full: str, results_shifts: str)
* commit {commit_sha} ({pr_tag}).

<p>
Please review the report below and
take corrective/congratulatory action as appropriate
Please review the report below and
take corrective/congratulatory action as appropriate
:slightly_smiling_face:
</p>
"""
Expand Down