Attempt at adding ImageMetaTag #209
Conversation
| @@ -0,0 +1,28 @@ | |||
| package: | |||
| name: image-meta-tag | |||
| version: "0.4" | |||
There was a problem hiding this comment.
For consistency and good practice, this should be changed to match the version number exactly (0.4.1)
|
|
||
| requirements: | ||
| build: | ||
| - python |
There was a problem hiding this comment.
The tests seem to pass with Python 2.7 but not with 3.4, so a switch can be put in here to test only with Python less than 3:
- python < 3
There is already an issue against ImageMetaTag for Python3 compatibility, to which I have added some of the test results:
MetOffice/image-meta-tag#8
| git_tag: 0.4.1 | ||
|
|
||
| build: | ||
| number: 0 |
There was a problem hiding this comment.
If the tests continue to fail on Appveyor (which tests the build on OSX), a switch can be put in here to not build on that system:
- skip: True # [osx]
But this may not be necessary unless Appveyor continues to fail today. Let's see how it goes.
There was a problem hiding this comment.
But in any case, all builds failed, and it appears to be because Continuum was not serving up Miniconda correctly.
There was a problem hiding this comment.
@QuLogic Yes quite right, apologies.
There was a problem hiding this comment.
@QuLogic Well not CircleCI, that was because the software is not compatible with Python3
There was a problem hiding this comment.
Ah, quite right. I don't think skipping them will make any difference though; the failure occurs much before the build stage has even started.
|
Leaving this here, for now, as the failing tests appear to be failing generally rather than specifically to my change. |
Hi @malcolmbrooks it seems that a bug has appeared in our build system, which is fixed as of #211 we need you to 'rebase' you branch onto upstream/master and update this PR please feel free to pop round and do it with us if you'd like to mark |
|
Hi @malcolmbrooks it appears that there was some change taking place on the remote testing systems, which required updates to this infrastructure i've taken your changes and rerun them in #213 and everything seems to build fine on all 3 platforms. If you are content for me to co-opt your work then we can close this and merge #213 which may be a little quicker mark |
|
Hi Mark, Malcolm |
No description provided.