Fix startup crash when published as self-contained single-file executable - #1436
Merged
iceljc merged 2 commits intoSep 16, 2026
Merged
Conversation
PluginLoader.Load() derived the plugin search directory from
Assembly.GetEntryAssembly().Location, which .NET leaves empty when
the app is published with PublishSingleFile + self-contained. That
made Directory.GetParent("") throw an ArgumentException before the
app could even start.
Use AppContext.BaseDirectory instead, which resolves correctly for
both regular and single-file-published deployments.
Fixes SciSharp#669
Covers the fix in the previous commit for SciSharp#669: verifies PluginLoader.Load() resolves its executing directory from AppContext.BaseDirectory (not Assembly.GetEntryAssembly().Location), and that it can still find and load a real plugin assembly from that directory.
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PluginLoader.Load()derived its plugin search directory fromAssembly.GetEntryAssembly().Location:.NET leaves
Locationempty ("") when the app is published as a self-contained, single-file executable (-p:PublishSingleFile=true --self-contained true).Directory.GetParent("")then throws, crashing the app before it can even start:Fixes #669
Fix
Use
AppContext.BaseDirectoryinstead, which resolves correctly for both regular and single-file-published deployments.Verification
dotnet publish -r linux-x64 --self-contained true -p:PublishSingleFile=trueand running the resulting binary directly — got the exact stack trace from Publish exception #669.dotnet run(the documented dev workflow) verified unaffected before and after.tests/BotSharp.Core.UnitTests/Plugins/PluginLoaderTests.cs:Load()doesn't throw and that the resolved executing directory matchesAppContext.BaseDirectoryBotSharp.Core.UnitTestssuite passes: 376/376.