feat: add Gauss Kronrod Adjoint #1235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,616 @@ | |||
| mutable struct GaussKronrodIntegrand{pType, uType, lType, rateType, S, PF, PJC, PJT, DGP, | |||
There was a problem hiding this comment.
All of this code should be unnecessary? Just reuse the other code instead of copy pasting. It should be like 10 lines total?
Comment on lines
+188
to
+198
| _, easy_res145k = adjoint_sensitivities(sol_nodense, Tsit5(), t = t, dgdu_discrete = dg, | ||
| abstol = 1e-14, | ||
| reltol = 1e-14, | ||
| sensealg = GaussKronrodAdjoint(checkpointing = true), | ||
| checkpoints = sol.t[1:500:end]) | ||
| _, easy_res146k = adjoint_sensitivities(sol_nodense, Tsit5(), t = t, dgdu_discrete = dg, | ||
| abstol = 1e-14, | ||
| reltol = 1e-14, | ||
| sensealg = GaussKronrodAdjoint(checkpointing = true, | ||
| autojacvec = false), | ||
| checkpoints = sol.t[1:500:end]) |
There was a problem hiding this comment.
The failure is checkpointing is doing something wrong here. But if you just delete and reuse the other code you should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Tests need fixing
Tests
145k, and146kare failing, even though they work if the callback of GaussAdjoint is replaced with IntegratingGKSum.