-
-
Notifications
You must be signed in to change notification settings - Fork 235
SciMLLogging Integration #2895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jClugstor
wants to merge
68
commits into
SciML:master
Choose a base branch
from
jClugstor:use_scimlverbosity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,801
−773
Open
SciMLLogging Integration #2895
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
f0277de
add verbosity types
jClugstor 6b03263
add imports
jClugstor b31b01a
unrestrict types
jClugstor dd06a72
ensure backwards compat
jClugstor e24bc4c
add SciMLMessage messages
jClugstor eca24a1
make constructors use kwargs
jClugstor 263eaa8
add AbstractVerbositySpecifier
jClugstor 674d3b1
add SciMLMessage imports
jClugstor 90bf91b
refactor ODEVerbosity
jClugstor 9d7ce88
update macro usage
jClugstor 487c819
rearrange
jClugstor 718ad71
add verbosity tests
jClugstor f5f84fa
imports and fixes for verbosity
jClugstor 233ea37
set linear verbosity to Minimal
jClugstor f89195e
set Nonlinear verbosity to Minimal
jClugstor 991bd67
fix imports
jClugstor af4659b
add verbosity options for the warnings in SciMLBase check_errors
jClugstor 3256489
remove bad getproperty
jClugstor 5a86f27
Update Project.toml
ChrisRackauckas 0bb110d
Update Project.toml
ChrisRackauckas d1f5312
Update Project.toml
ChrisRackauckas 3440085
Update Project.toml
ChrisRackauckas 57e79e3
Update Project.toml
ChrisRackauckas 0e47f99
Update Project.toml
ChrisRackauckas 0a05e3c
Update Project.toml
ChrisRackauckas 53765a5
Update Project.toml
ChrisRackauckas e5d4bcf
make ODEVerbosity concrete in DEOptions
jClugstor 908c4f9
add manual page for verbosity
jClugstor b0843cf
fix DEOptions constructor
jClugstor 1163230
bump OrdinaryDiffEqCore version
jClugstor 7c0ee0d
bump lower bounds for OrdinaryDiffEqCore
jClugstor 2c0597a
add verbose as argument to all alg_cache
jClugstor 0ea3118
thread verbose in to build_nlsolver
jClugstor ac633a3
fix verbose for default caches
jClugstor d899605
fix up some verbosity and linear verbosity
jClugstor b1858ac
add test for nonlinearsolve verbosity passthrough
jClugstor d3f14dc
fix check_error test
jClugstor dbec897
fix FBDF dae tests
jClugstor e9b11ff
fix sources for ExponentialRK Tsit5
jClugstor 5b2906b
fix test source for OrdinaryDiffEqRosenbrock for ODELinear
jClugstor a84745c
fix source of OrdinaryDiffEqSDIRK for OrdinaryDiffEqNonlinearSolve
jClugstor 5163b43
fix source of OrdinaryDiffEqTsit5 for OrdinaryDiffEqSymplecticRK
jClugstor 5b5bae4
fix source of SDIRK for ImplicitDiscreteSolve
jClugstor e890349
remove unused @SciMLMessage in OrdinaryDiffEqBDF
jClugstor cfa5c5b
fix source of OrdinaryDiffEqRKN for OrdinaryDiffEqBDF
jClugstor 723757b
add several verbosity toggles
jClugstor 067835c
add several verbosity toggles
jClugstor 4547271
fix the None constructor
jClugstor 6206ade
add stiff detection toggle
jClugstor 627fe0d
add instability toggle back for SciMLBase
jClugstor d8d1447
use lazy strings for interpolation
jClugstor a818ea4
fix step rejected message
jClugstor f0542e1
bump all library minor versions
jClugstor fe0afcd
remove unused SciMLMessages
jClugstor c6e8f89
fix generic rosenbrock caches
jClugstor f105fc3
back compat for DelayDiffEq
jClugstor 56e821d
use nonlinear verbosity in _initialize_dae!
jClugstor 14b6447
remove bad backwards compat
jClugstor 17afac9
backwards compat for stochasticdiffeq and delaydiffeq
jClugstor f9ecd33
move deprecated alg_cache and build_nlsolver to deprecated files
jClugstor 1985af0
remove message in loopheader so Delay and StochasticDiffEq work
jClugstor 5b78108
add another dep path for oop
jClugstor 0d6e662
put loopheader messages back
jClugstor 96ba527
fix alg_cache for CG4a
jClugstor 8653c49
inferrable default path, make grouping more inferrable
jClugstor 939dbf9
use multiple dispatch for handling verbose kwarg
jClugstor f277e96
add generated path for ODEVerbosity constructor
jClugstor 24b600d
fix up the verbosity tests
jClugstor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Controlling Solver Verbosity | ||
|
|
||
| OrdinaryDiffEq.jl provides fine-grained control over diagnostic messages, warnings, and errors | ||
| through the `verbose` keyword argument for `solve`. The verbosity system allows you to control what | ||
| information is displayed during the solve process. See [SciMLLogging.jl](https://docs.sciml.ai/SciMLLogging/dev/) for more details. | ||
|
|
||
| ```@docs | ||
| ODEVerbosity | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| name = "ImplicitDiscreteSolve" | ||
| uuid = "3263718b-31ed-49cf-8a0f-35a466e8af96" | ||
| authors = ["vyudu <[email protected]>"] | ||
| version = "1.2.0" | ||
| version = "1.3.0" | ||
|
|
||
| [deps] | ||
| SimpleNonlinearSolve = "727e6d20-b764-4bd8-a329-72de5adea6c7" | ||
|
|
@@ -24,7 +24,7 @@ Test = "1.10.0" | |
| OrdinaryDiffEqSDIRK = "1.6.0" | ||
| SciMLBase = "2.99" | ||
| SimpleNonlinearSolve = "2.7" | ||
| OrdinaryDiffEqCore = "1.29.0" | ||
| OrdinaryDiffEqCore = "1.37.0" | ||
| Aqua = "0.8.11" | ||
| SymbolicIndexingInterface = "0.3.38" | ||
| julia = "1.10" | ||
|
|
@@ -39,3 +39,6 @@ test = ["OrdinaryDiffEqSDIRK", "Test", "JET", "Aqua", "AllocCheck"] | |
|
|
||
| [sources.OrdinaryDiffEqCore] | ||
| path = "../OrdinaryDiffEqCore" | ||
|
|
||
| [sources.OrdinaryDiffEqSDIRK] | ||
| path = "../OrdinaryDiffEqSDIRK" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| name = "OrdinaryDiffEqAdamsBashforthMoulton" | ||
| uuid = "89bda076-bce5-4f1c-845f-551c83cdda9a" | ||
| authors = ["ParamThakkar123 <[email protected]>"] | ||
| version = "1.5.0" | ||
| version = "1.6.0" | ||
|
|
||
| [deps] | ||
| Reexport = "189a3867-3050-52da-a836-e630ba90ab69" | ||
|
|
@@ -33,7 +33,7 @@ DiffEqDevTools = "2.44.4" | |
| MuladdMacro = "0.2" | ||
| Polyester = "0.7" | ||
| SciMLBase = "2.99" | ||
| OrdinaryDiffEqCore = "1.29.0" | ||
| OrdinaryDiffEqCore = "1.37.0" | ||
| Static = "1.2" | ||
| OrdinaryDiffEqLowOrderRK = "1.5.0" | ||
| Aqua = "0.8.11" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| name = "OrdinaryDiffEqBDF" | ||
| uuid = "6ad6398a-0878-4a85-9266-38940aa047c8" | ||
| authors = ["ParamThakkar123 <[email protected]>"] | ||
| version = "1.10.0" | ||
| version = "1.11.0" | ||
|
|
||
| [deps] | ||
| FastBroadcast = "7034ab61-46d4-4ed7-9d0f-46aef9175898" | ||
|
|
@@ -45,14 +45,14 @@ FastBroadcast = "0.3" | |
| Random = "<0.0.1, 1" | ||
| DiffEqDevTools = "2.44.4" | ||
| MuladdMacro = "0.2" | ||
| LinearSolve = "3.26" | ||
| LinearSolve = "3.46" | ||
| PrecompileTools = "1.2" | ||
| LinearAlgebra = "1.10" | ||
| OrdinaryDiffEqDifferentiation = "1.12.0" | ||
| OrdinaryDiffEqSDIRK = "1.6.0" | ||
| TruncatedStacktraces = "1.4" | ||
| SciMLBase = "2.99" | ||
| OrdinaryDiffEqCore = "1.29.0" | ||
| OrdinaryDiffEqCore = "1.37.0" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this required? |
||
| Aqua = "0.8.11" | ||
| ArrayInterface = "7.19" | ||
| Enzyme = "0.13" | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DiffEqDocs needs a PR that explains it in more detail how it's a solver-package specific thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it makes it a bit rough for it to be solver-specific... since then you cannot do things in benchmarks and optimization more generally.