Add callable parameter based interface #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Implements #54 (comment) and makes the lux model a callable parameter in the
NeuralNetworkBlock
(as mentioned in #51 (comment))Needs JuliaSymbolics/Symbolics.jl#1508 (for 774aba9 only. If this is an issue I can split this PR in 2).
@ChrisRackauckas Is the new interface okay?
I might need a bit of help on how to write the parameters more generically, since right now the names are hardcoded.
I suspect I can't use the macro form.
I was also thinking of having
get_network
work on anODESystem
and retrieve the neural network in theNeuralNetworkBlock
case, but I'm not sure how can I check that theODESystem
is aNeuralNetworkBlock
. We could just assume it is and just reach out for the expected name and hope for the best 😅