Skip to content

refactor: default create_bindings to false in build_function_wrapper #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ StaticArrays = "0.10, 0.11, 0.12, 1.0"
StochasticDiffEq = "6.72.1"
StochasticDelayDiffEq = "1.8.1"
SymbolicIndexingInterface = "0.3.37"
SymbolicUtils = "3.10.1"
Symbolics = "6.27"
SymbolicUtils = "3.14"
Symbolics = "6.29"
URIs = "1"
UnPack = "0.1, 1.0"
Unitful = "1.1"
Expand Down
18 changes: 9 additions & 9 deletions docs/src/systems/DiscreteSystem.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,20 @@
DiscreteSystem
```

## Composition and Accessor Functions

- `get_eqs(sys)` or `equations(sys)`: The equations that define the discrete system.
- `get_unknowns(sys)` or `unknowns(sys)`: The set of unknowns in the discrete system.
- `get_ps(sys)` or `parameters(sys)`: The parameters of the discrete system.
- `get_iv(sys)`: The independent variable of the discrete system
- `discrete_events(sys)`: The set of discrete events in the discrete system.
## Composition and Accessor Functions

- `get_eqs(sys)` or `equations(sys)`: The equations that define the discrete system.
- `get_unknowns(sys)` or `unknowns(sys)`: The set of unknowns in the discrete system.
- `get_ps(sys)` or `parameters(sys)`: The parameters of the discrete system.
- `get_iv(sys)`: The independent variable of the discrete system
- `discrete_events(sys)`: The set of discrete events in the discrete system.

## Transformations

```@docs; canonical=false
structural_simplify
```

## Problem Constructors

```@docs; canonical=false
Expand Down
2 changes: 1 addition & 1 deletion src/systems/codegen_utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ function build_function_wrapper(sys::AbstractSystem, expr, args...; p_start = 2,
p_end = is_time_dependent(sys) ? length(args) - 1 : length(args),
wrap_delays = is_dde(sys), wrap_code = identity,
add_observed = true, filter_observed = Returns(true),
create_bindings = true, output_type = nothing, mkarray = nothing,
create_bindings = false, output_type = nothing, mkarray = nothing,
wrap_mtkparameters = true, extra_assignments = Assignment[], kwargs...)
isscalar = !(expr isa AbstractArray || symbolic_type(expr) == ArraySymbolic())
# filter observed equations
Expand Down
Loading