Skip to content

WIP: BVP Out of Place Linear problems #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

n0rbed
Copy link

@n0rbed n0rbed commented Mar 13, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • Any new documentation only uses public API

@n0rbed
Copy link
Author

n0rbed commented Mar 13, 2025

This is made to aid the testing of SciML/SimpleBoundaryValueDiffEq.jl#13

@ErikQQY
Copy link
Member

ErikQQY commented Mar 13, 2025

I think the current in-place version test cases in BVProblemLibrary.jl is fine, if you want OOP cases, you can just put them in the tests of SimpleBoundaryValueDiffEq.jl

@n0rbed
Copy link
Author

n0rbed commented Mar 13, 2025

Writing that many problems in SimpleBoundaryBVP seems overkill, plus we may need these elsewhere, so rewriting them would be bad, what do u think?

@ErikQQY
Copy link
Member

ErikQQY commented Mar 13, 2025

We don’t have to test convergence on all test problems, since these are linear BVPs with analytical solutions, it’s enough as long as we can show the implemented solver have specific convergence order. I suggest you take a look at how we are doing in BoundaryValueDiffEq.jl convergence test for MIRK and FIRK methods.

@ChrisRackauckas
Copy link
Member

It would be good to just get these here if we can. Might asw well make them reusable.

@n0rbed
Copy link
Author

n0rbed commented Mar 31, 2025

Not sure if @SVector should be used for all the OOP functions' residual or not, so only the first two problems are that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants