build: upgrade angular version to v19 #1832
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and DTOs - Updated `datasetsControllerCount` to `datasetsControllerCountV3` in PoliciesDashboardComponent. - Changed date input types in ProposalFilterComponent and DateRangeFilterComponent to `any`. - Refactored SampleDetailComponent to use `CreateAttachmentV3Dto` and `OutputAttachmentV3Dto`. - Modified TableVirtualScrollDataSource to emit `null` in filter updates. - Updated FileUploaderComponent to use `OutputAttachmentV3Dto` for attachments. - Changed thumbnail service to use `datasetsControllerThumbnailV3`. - Refactored actions in datasets, proposals, samples, and user management to use new DTOs and API methods. - Updated effects for datasets, instruments, jobs, logbooks, policies, proposals, published data, samples, and user management to utilize new API versions. - Removed unused imports and adjusted state management to reflect new DTOs.
…-eslint/schematics to version 17.5.3
…evtoolsModule configuration
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Junjiequan - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using feature flags to enable the new API endpoints instead of directly replacing the old ones.
- It looks like there are a lot of API changes from v3 to v4, so make sure you've handled all the breaking changes.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- Updated Angular packages in package.json to version 18.2.13 for core modules, animations, forms, and others. - Updated Angular DevKit packages to version 18.2.19. - Refactored app.module.ts to use provideHttpClient and withInterceptorsFromDi for HTTP client configuration. - Adjusted imports in various spec files to use provideHttpClient and removed HttpClientModule where applicable. - Cleaned up unnecessary imports and improved the structure of the app.module.ts. - Removed deprecated TypeScript compiler options from tsconfig.json.
fix some warnings
Junjiequan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Short description of the pull request
Motivation
Background on use case, changes needed
Fixes:
Please provide a list of the fixes implemented in this PR
Changes:
Please provide a list of the changes implemented by this PR
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version
Summary by Sourcery
Upgrade SciCat frontend to Angular version 19 and update related dependencies and API calls
New Features:
Enhancements:
Chores: