Skip to content

POC: use the instruments complete endpoint that returns both paginated data and totalCount #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Apr 4, 2025

Description

Short description of the pull request

Motivation

Background on use case, changes needed

Fixes:

Please provide a list of the fixes implemented in this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Refactor the instruments dashboard to use a new complete endpoint that returns both paginated data and total count, improving data fetching and table functionality

New Features:

  • Implement server-side pagination and sorting for instruments dashboard
  • Add global text search functionality for instruments table

Enhancements:

  • Migrate to a more flexible dynamic material table component
  • Improve state management for instruments dashboard
  • Enhance query parameter handling for table interactions

Tests:

  • Update unit tests to reflect new implementation
  • Add Cypress test for instrument dashboard functionality

Chores:

  • Remove deprecated actions and reducers related to pagination and sorting
  • Simplify state management logic

@martin-trajanovski martin-trajanovski changed the title feat: use the instruments complete endpoint that returns both paginated data and totalCount POC: use the instruments complete endpoint that returns both paginated data and totalCount Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant