No dylib des #192
Closed
No dylib des #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve compatibilty and build errors on build_cc/cmake for windows
null catches
In testing I noticed an almost doubling of test time between build_cc and cmake, they are now unified to make sure there is reduced chance of difference between builds. also enabled ability to read build environment of allocator
|
Interesting lto does not work for cc or gcc on x86_64 |
|
@mjp41 any ideas why cmake lto flag fails on msvc, ubuntu cc compiler with file format not recognized errors? |
Have a feeling I need println!("cargo::rustc-flags=-Clinker-plugin-lto"); I'll test later today |
|
Sorry, this is not my area of expertise. I can try and investigate on a Windows machine if you get stuck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removal of dylib