Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update proposal. #176

Merged
merged 1 commit into from
Feb 10, 2024
Merged

update proposal. #176

merged 1 commit into from
Feb 10, 2024

Conversation

devnexen
Copy link
Collaborator

  • snmalloc to last version.
  • then adding a handful of available build options, diabling TLS support and LTO linkage.

SchrodingerZhu
SchrodingerZhu approved these changes Feb 10, 2024
View reviewed changes
Copy link
Owner

@SchrodingerZhu SchrodingerZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have submitted a separate CI fix.

@SchrodingerZhu
Copy link
Owner

SchrodingerZhu commented Feb 10, 2024 •
edited
Loading

For simplicity, I relaxed signed commit protection for main. Feel free to re-enable it if you find it proper.

To make signed commit, you will need to setup your GPG key with git. I personally almost always use git commit -Ss to create commits but it is just my own preference.

See also: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@devnexen
update proposal.
4bc55bd 
- snmalloc to last version.
- then adding a handful of available build options, diabling TLS support and LTO linkage.

Signed-off-by: David Carlier <[email protected]>
@devnexen devnexen merged commit e0e4bfa into SchrodingerZhu:master Feb 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchrodingerZhu SchrodingerZhu SchrodingerZhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @SchrodingerZhu