Updated the plugin to work with SceneView 2.2.1 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've been working all this week on updating this plugin.
I've updated the Flutter dependencies, as well as the code formatting and fixed issues related to the Flutter linter.
I've updated Gradle to version 8 and added prog-guard so it compiles correctly when activating ArCore services.
I've also implemented the event channel so anyone who wants to use this plugin can create a branch and add the events they need. I've also optimized the method channel for easy use from the controller.
I hope you like these changes and will take the time to review them.
Things I haven't been able to get working correctly:
When running Flutter's hot-reload, the plugin doesn't work properly and the app closes, but if you launch it without hot-reload, it works correctly.
When creating a view in Flutter with only the SceneView, closing this view would crash the app. #408 I solved this by waiting for the SceneView controller to dispose completely and encapsulating the view with a PopScope. It's the only way I've found to prevent the app from closing unexpectedly.