Charamel ws plugin #191
Open
Charamel ws plugin #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
* actor id no longer hard coded * generate UUIDs instead of having them statically
…d. Removed some commented out debug messages.
algor1th
commented
Aug 17, 2020
| this.addWs(ctx); | ||
| mLogger.message("Connected to Charamel VuppetMaster"); | ||
| ctx.send(Strings.launchString); | ||
| // 17.8.2020 PG - deactivated - Do we need a launch string? ctx.send(Strings.launchString); |
There was a problem hiding this comment.
No, it is useful for testing. No point for it beyond that
…tion. Mode debug messages
# Conflicts: # build.gradle
algor1th
commented
Sep 30, 2020
| public void launch() { | ||
| mLogger.message("Loading Charamel VuppetMaster Executor (WebSocket) ..."); | ||
| final int port = Integer.parseInt(Objects.requireNonNull(mConfig.getProperty("port"))); | ||
| final String sceneflowVar =mConfig.getProperty("sceneflowVar"); |
| mLogger.message("Connected to Charamel VuppetMaster"); | ||
|
|
||
| // let sceneflow know that a client has connected | ||
| if (mProject.hasVariable(sceneflowVar)) { |
There was a problem hiding this comment.
scenefloVar may be null, which leads to a crash here
… message to sceneflow variable
…option in cases where the REQUEST will lead to multiple instances of radio button inputs. Also contains corresponding updates to the studymaster-web example project where all the REQUEST fields have been doubled to verify and record the functioning of multiple input instances of the same type.
…ight teh right selected option in cases where the REQUEST will lead to multiple instances of radio button inputs.
…empty upon starting and ending the studymaster session i.e. when the play and stop button are pressed in VSM.
…t based studymaser system.
# Conflicts: # plugins/studymaster-web/ExampleProject/studymaster-web/sceneflow.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.