Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional refer_to_ghost_records parameter to pit macros #313

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

tkiehn
Copy link
Collaborator

@tkiehn tkiehn commented Jan 31, 2025

Description

Add optional parameter to pit macro which determines if for null satellite hashkeys the ghost record should be referenced. Default is true, same as the old behavior

@tkiehn tkiehn requested a review from tkirschke January 31, 2025 09:27
@tkiehn tkiehn added the testing To trigger the automated test workflow as internal User. label Jan 31, 2025
@remoteworkflow

This comment was marked as outdated.

@remoteworkflow remoteworkflow bot removed the testing To trigger the automated test workflow as internal User. label Jan 31, 2025
@tkiehn tkiehn added the testing To trigger the automated test workflow as internal User. label Jan 31, 2025
@remoteworkflow

This comment was marked as outdated.

@remoteworkflow remoteworkflow bot removed the testing To trigger the automated test workflow as internal User. label Jan 31, 2025
@tkiehn tkiehn added the testing To trigger the automated test workflow as internal User. label Jan 31, 2025
@remoteworkflow

This comment was marked as outdated.

@remoteworkflow remoteworkflow bot removed the testing To trigger the automated test workflow as internal User. label Jan 31, 2025
@tkiehn tkiehn added testing To trigger the automated test workflow as internal User. and removed testing To trigger the automated test workflow as internal User. labels Jan 31, 2025
@remoteworkflow

This comment was marked as outdated.

@remoteworkflow remoteworkflow bot removed the testing To trigger the automated test workflow as internal User. label Feb 3, 2025
…t' into 178-pit-new-parameter-refer_to_ghost_records
@tkiehn tkiehn added the testing To trigger the automated test workflow as internal User. label Feb 6, 2025
@remoteworkflow
Copy link

remoteworkflow bot commented Feb 6, 2025

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/13176956935


RESULTS for Synapse:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Postgres:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for BigQuery:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Redshift:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Snowflake:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Exasol:
❌ dbt-tests
✅ dbt-macro-tests


RESULTS for Fabric:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Oracle:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Databricks:
✅ dbt-tests
✅ dbt-macro-tests

@remoteworkflow remoteworkflow bot removed the testing To trigger the automated test workflow as internal User. label Feb 6, 2025
@tkirschke tkirschke merged commit 897d6de into main Feb 6, 2025
@tkiehn tkiehn deleted the 178-pit-new-parameter-refer_to_ghost_records branch February 6, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants