[llimeht]

Description

Tweak tests of colormaps to be independent (or at least less dependent) on the matplotlib version, fixing current issues and saving future ones.

Fixes #4000

How Has This Been Tested?

CI tests now pass

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

• There is nothing that needs documenting
• Documentation changes are in this PR
• There is an issue open for the documentation (link?)

Installers

• There is a chance this will affect the installers, if so
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)
  • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

• The introduced changes comply with SasView license (BSD 3-Clause)

[pkienzle]

Ask mpl for the color map lists so you can use actual target values.

Also, change line 115 to assert mpl_colormaps[20] in spy_apply.called()[0]['args'][1] rather than testing against 'RdYlBu_r' so that it will not fail when the order of the color maps changes.

[llimeht]

Ask mpl for the color map lists so you can use actual target values.

I've seen that strategy fail too many times in the past (loading the set fails silently for some reason and you've carefully established that 0 == 0 when the test really should have failed because you know you should have 150 items. My preference is normally to use a sensible lower bound. (I've played this game with modules that had tests for the number of countries or counties in a data set...).

So 'perhaps'.

Also, change line 115 to assert mpl_colormaps[20] in spy_apply.called()[0]['args'][1] rather than testing against 'RdYlBu_r' so that it will not fail when the order of the color maps changes.

I have no doubt that there are many more such items - there are at least a few more in that file (… == 47 stands out). I likely won't be finding time soon to fix them though - if others have the time and energy, they should be able to push to this branch to do so.

[krzywon]

This is a more reasonable change than my xfail. I think this should be merged to fix our on-going CI failures.