Improved syntaxis

Author: SantiSnow

Block/Product.php

@@ -20,27 +20,6 @@ public function getStructuredJsonData(): string
 
         $shortDescription = trim(preg_replace('/ +/', ' ', preg_replace('/[^A-Za-z0-9 ]/', ' ', urldecode(html_entity_decode(strip_tags($productBasicInformation['short_description']))))));
 
-        $structuredData = "{";
-        $structuredData .= '"@context": "https://schema.org/",' . "\n\r";
-        $structuredData .= '"@type": "Product",' . PHP_EOL;
-        $structuredData .= '"name": "'.$productBasicInformation->getName().'",' . "\n\r";
-        $structuredData .= '"sku": "'.$productBasicInformation->getSku().'",' . "\n\r";
-        $structuredData .= '"description": "'.$shortDescription.'",' . "\n\r";
-        $structuredData .= '"image": ["'.$productBasicInformation->getMediaConfig()->getMediaUrl($productBasicInformation->getImage()).'"]' . "\n\r";
-        $structuredData .= "}";
-
-        return $structuredData;
-    }
-
-    /**
-     * @return string
-     */
-    public function getStructuredJsonDataAsArray(): string
-    {
-        $productBasicInformation = $this->getProduct();
-
-        $shortDescription = trim(preg_replace('/ +/', ' ', preg_replace('/[^A-Za-z0-9 ]/', ' ', urldecode(html_entity_decode(strip_tags($productBasicInformation['short_description']))))));
-
         $structuredData = [];
         $structuredData["@context"]= "https://schema.org/";
         $structuredData["@type"]= 'Product';
@@ -51,4 +30,5 @@ public function getStructuredJsonDataAsArray(): string
 
         return json_encode($structuredData);
     }
+
 }

view/frontend/templates/custom_tab.phtml

@@ -9,5 +9,5 @@
 
 $currentProduct = $block->getProduct();
 echo '<script type="application/ld+json">';
-echo $block->getStructuredJsonDataAsArray();
+echo $block->getStructuredJsonData();
 echo '</script>';