Improved syntaxis

Author: SantiSnow

.gitignore

@@ -6,12 +6,14 @@
 
 namespace Osaka\StructuredData\Block;
 
-use Magento\Backend\Block\Template\Context;
-use Magento\Catalog\Helper\Data;
 use Magento\Catalog\Block\Product\View;
 
 class Product extends View
 {
+
+    /**
+     * @return string
+     */
     public function getStructuredJsonData(): string
     {
         $productBasicInformation = $this->getProduct();
@@ -25,11 +27,28 @@ public function getStructuredJsonData(): string
         $structuredData .= '"sku": "'.$productBasicInformation->getSku().'",' . "\n\r";
         $structuredData .= '"description": "'.$shortDescription.'",' . "\n\r";
         $structuredData .= '"image": ["'.$productBasicInformation->getMediaConfig()->getMediaUrl($productBasicInformation->getImage()).'"]' . "\n\r";
-
         $structuredData .= "}";
 
+        return $structuredData;
+    }
+
+    /**
+     * @return string
+     */
+    public function getStructuredJsonDataAsArray(): string
+    {
+        $productBasicInformation = $this->getProduct();
 
+        $shortDescription = trim(preg_replace('/ +/', ' ', preg_replace('/[^A-Za-z0-9 ]/', ' ', urldecode(html_entity_decode(strip_tags($productBasicInformation['short_description']))))));
 
-        return $structuredData;
+        $structuredData = [];
+        $structuredData["@context"]= "https://schema.org/";
+        $structuredData["@type"]= 'Product';
+        $structuredData["name"] = $productBasicInformation->getName();
+        $structuredData["sku"] = $productBasicInformation->getSku();
+        $structuredData["description"] = $shortDescription;
+        $structuredData["image"] = array($productBasicInformation->getMediaConfig()->getMediaUrl($productBasicInformation->getImage()));
+
+        return json_encode($structuredData);
     }
 }

Block/Product.php

@@ -15,7 +15,7 @@ class ProductManagement implements \Osaka\StructuredData\Api\ProductManagementIn
      */
     public function getProduct($param)
     {
-        return 'hello api GET return the $param ' . $param;
+
     }
 }
 

Model/ProductManagement.php

@@ -9,5 +9,5 @@
 
 $currentProduct = $block->getProduct();
 echo '<script type="application/ld+json">';
-print_r($block->getStructuredJsonData());
+echo $block->getStructuredJsonDataAsArray();
 echo '</script>';