PORTALS-3382 #1554
PORTALS-3382 #1554
Conversation
| if (selectedTabIndex == undefined && allCountsSet) { | ||
| // navigate to the tab that has the highest count | ||
| const maxCountTab = searchPageTabs.reduce((max, tab) => | ||
| max === null || tab.count! > max.count! ? tab : max, |
There was a problem hiding this comment.
I think it's ok. I might suggest splitting the null case from the comparison with the accumulator. The tricky thing about this statement is trying to remember order of operations between a ternary, ||, >, and ===.
That said, I don't know that you need a null check here. The initial value will be searchPageTabs[0], so max should never be null.
So I'd either separate the null check into its own statement and specify a null initial value or remove it altogether
|
Adds a loading UI (while the initial queries are executed), and navigates to the tab with the max count once all counts are set. |
| {selectedTabIndex != undefined && ( | ||
| <PortalSearchTabs tabConfig={searchPageTabsState} /> | ||
| )} |
There was a problem hiding this comment.
Ah, so you effectively won't even show the tabs until you have a query. This order of interactions is making more sense to me
No description provided.