Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORTALS-3406 - Fix missing route #1550

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

nickgros
Copy link
Collaborator

@nickgros nickgros commented Feb 3, 2025

No description provided.

@nickgros nickgros changed the title SWC-7237 - Rename hook for clarity PORTALS-3406 - Fix missing route Feb 4, 2025
Comment on lines +74 to +77
<Route
path={'signUpdatedTermsOfUse'}
element={<SignUpdatedTermsOfUsePage />}
/>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add back the missing route

@@ -42,7 +43,7 @@ function LoggedInRedirector() {
const isProviderSearchParam = getSearchParam('provider') !== undefined
const isInSSOFlow = isCodeSearchParam && isProviderSearchParam

const { mayPromptTermsOfUse } = useMaybeRedirectToSignTermsOfService()
const { mayPromptTermsOfUse } = useMaybePromptToSignTermsOfService()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed hook per code review

@nickgros nickgros merged commit c4a7298 into Sage-Bionetworks:main Feb 4, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants