Consolidate calls to createPlotlyComponent #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
commented
Feb 3, 2025
There was a problem hiding this comment.
Component is no longer used.
Some bundlers (like esbuild) do not produce expected output when bundling react-plotly.js/factory (I think it has unusual CJS syntax). I consolidated usage of this to one module to simplify debugging, but it's a generally-useful refactor.
nickgros
force-pushed
the
PORTALS-3253c
branch
from
74caca9 to
5624883
Compare
…b-monorepo into PORTALS-3253c
nickgros
commented
Feb 4, 2025
| import rawData from '../../mocks/distribution_data.json' | ||
| import Plotly from 'plotly.js-basic-dist' | ||
|
|
||
| const meta = { | ||
| title: 'Components/PlotlyWrapper', | ||
| component: PlotlyWrapper, | ||
| title: 'Components/PlotlyPlot', |
There was a problem hiding this comment.
Update story to just use the Plot component instead of the unused PlotlyWrapper component
jay-hodgson
approved these changes
Feb 4, 2025
jay-hodgson
reviewed
Feb 4, 2025
| @@ -143,7 +142,6 @@ const SynapseComponents = { | |||
| displayToast, | |||
| IconSvg, | |||
| UserProfileLinks, | |||
| PlotlyWrapper, | |||
There was a problem hiding this comment.
I think we ran a POC with utilizing this in Agora at one point, but I think Agora is only using SRC for rendering Synapse Wikis now (@sagely1 or @hallieswan , could you confirm?)
There was a problem hiding this comment.
A search in Sage-Bionetworks/sage-monorepo tells me that no projects there, including Agora, are currently using synapse-react-client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bundlers (like esbuild) do not produce expected output when bundling react-plotly.js/factory (I think it has unusual CJS syntax). I consolidated usage of this to one module to simplify debugging, but it's a generally-useful refactor.