PORTALS-2651 #1547
Merged
PORTALS-2651 #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Bootstrap CSS and dependencies - Remove Downshift (no longer used) - Remove some missed bootstrap classes
nickgros
force-pushed
the
PORTALS-2651-css
branch
from
3093c3e to
fa153cf
Compare
nickgros
commented
Feb 5, 2025
| @@ -201,7 +201,6 @@ export const EntityUpload = forwardRef(function EntityUpload( | |||
| /> | |||
| {/* File input */} | |||
| <input | |||
| className="form-control" | |||
| type="file" | |||
| id="filesToUpload" | |||
| name="file upload" | |||
There was a problem hiding this comment.
These inputs with form-control are not visible, so removing the class doesn't matter
nickgros
commented
Feb 5, 2025
Comment on lines
+723
to
731
| // TODO: Remove * ? | ||
| * a.ignoreLink:not(.btn, .MuiLink-root, .MuiButton-root) { | ||
| @include SRC_Mixins.ignoreLink; | ||
| &:visited, | ||
| &:active, | ||
| &:link { | ||
| @include SRC_Mixins.ignoreLink; | ||
| &:visited, | ||
| &:active, | ||
| &:link { | ||
| @include SRC_Mixins.ignoreLink; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This selector touches a lot, and isn't bootstrap-specific, so I left it, even though I want to remove it.
- react-bootstrap usage was removed - react-app-polyfill is no longer used (we do not use CRA and synapse-react-client is not a standalone web application) - prop-types is unused, and we use TypeScript
nickgros
commented
Feb 5, 2025
| "classnames": "^2.5.1", | ||
| "dagre": "^0.8.5", | ||
| "dayjs": "^1.11.10", | ||
| "downshift": "^6.1.12", |
There was a problem hiding this comment.
was previously used in UserSearchBox (v1), is no longer used
nickgros
commented
Feb 5, 2025
| @@ -88,11 +86,8 @@ | |||
| "plotly.js": "2.28.0", | |||
| "plotly.js-basic-dist": "^2.30.0", | |||
| "pluralize": "^8.0.0", | |||
| "prop-types": "^15.8.1", | |||
There was a problem hiding this comment.
Not used, plus not needed since we use TypeScript
nickgros
commented
Feb 5, 2025
| "qrcode": "^1.5.3", | ||
| "raf": "^3.4.1", | ||
| "react-app-polyfill": "^3.0.0", |
There was a problem hiding this comment.
Not used since synapse-react-client used create-react-app (a while ago!)
jay-hodgson
reviewed
Feb 5, 2025
| headline1: 'p', | ||
| headline2: 'p', | ||
| headline3: 'p', | ||
| headline1: 'h1', |
There was a problem hiding this comment.
I think using ranked headings is an accessibility win as well
jay-hodgson
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove bootstrap 4 and react-bootstrap