PORTALS-2651 - react-select components #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
force-pushed
the
PORTALS-2651-select
branch
from
0965b96 to
9358ad9
Compare
- Update UserSearchBoxV2, QuerySortSelector, AccessRequirementSearchBox to no longer use bootstrap classes - Remove UserSearchBox v1
nickgros
force-pushed
the
PORTALS-2651-select
branch
from
9358ad9 to
5bf311f
Compare
nickgros
commented
Feb 4, 2025
nickgros
commented
Feb 4, 2025
| ) | ||
| }, | ||
| } | ||
|
|
||
| export default function AccessRequirementSearchBox( |
nickgros
commented
Feb 4, 2025
| @@ -181,8 +174,7 @@ function UserSearchBoxV2(props: UserSearchBoxProps) { | |||
| isClearable | |||
| value={value} | |||
| styles={{ | |||
| // Bootstrap's form-control class overrides the display value, manually set to flex (the default without Bootstrap) | |||
| control: styles => ({ ...styles, display: 'flex !important' }), | |||
| control: styles => ({ ...styles, backgroundColor: palette.grey[200] }), | |||
nickgros
commented
Feb 4, 2025
| </components.Control> | ||
| ) | ||
| } | ||
|
|
||
| function QuerySortSelector({ sortConfig }: QuerySortSelectorProps) { |
nickgros
changed the title
jay-hodgson
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some bootstrap-specific classes