Fixes .hdr+.cab installshield cabinet files not being extracted by BOS when relative paths are provided. #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…relative paths are provided.
…/en-us/dotnet/api/system.io.path.getfullpath?view=net-9.0 listing several more exceptions than the other functions, most of which I would not imagine should be directly handled.
mnadareski
reviewed
Jun 30, 2025
|
If the comment above isn't going to be addressed, then I'll close this. Making this PR work should not take a lot of extra code. |
|
Oh, sorry, I just missed the response. I'll work on it soon. |
…er via filestream name instead.
…ed assert.throws exception for empty paths in the unit tests
mnadareski
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installshield .hdr+.cab archives were not being extracted by BOS when relative paths were provided. Let me know if this is an improper fix- I tried to look for similar functions in other extractors, but as far as I can tell, nothing else is written exactly like this bit.
Apologies for closing and re-opening the pull request, but since this is a problem that affects no other part of BOS and is unique to this specific part of ISCAB due to nothing else working like it, I had assumed i was fine to just commit directly to master and it would be a quick merge. It's understandable that this might need further investigation, but I need to make other PRs and I don't want to destroy my own git history, so I had to move my commits to a different branch and roll back master after the fact.