Skip to content

Fix message load indicator positions #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7w1 merged 1 commit into from
May 15, 2026
+33 −13
Merged

Fix message load indicator positions #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-timeline-pagination-spinner-layout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: patch
---

Properly centered message loading indicators to avoid brief scrollbar shift while loading messages.
41 changes: 28 additions & 13 deletions src/app/features/room/RoomTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,12 +720,6 @@ export function RoomTimeline({
</Chip>
</Box>
);
} else if (timelineSync.backwardStatus === 'loading' && timelineSync.eventsLength > 0) {
backPaginationJSX = (
<Box justifyContent="Center" style={{ padding: config.space.S300 }}>
<Spinner variant="Secondary" size="400" />
</Box>
);
}
}

Expand All @@ -752,15 +746,20 @@ export function RoomTimeline({
</Chip>
</Box>
);
} else if (timelineSync.forwardStatus === 'loading' && timelineSync.eventsLength > 0) {
frontPaginationJSX = (
<Box justifyContent="Center" style={{ padding: config.space.S300 }}>
<Spinner variant="Secondary" size="400" />
</Box>
);
}
}

const showBackPaginationSpinner =
timelineSync.backwardStatus === 'loading' && timelineSync.eventsLength > 0;
const showFrontPaginationSpinner =
timelineSync.forwardStatus === 'loading' && timelineSync.eventsLength > 0;
const timelineBottomFloatLift =
!atBottomState && isReady ? { bottom: `calc(${config.space.S400} + ${toRem(52)})` } : undefined;
const timelineTopFloatLift =
unreadInfo?.readUptoEventId && !unreadInfo?.inLiveTimeline && isReady
? { top: `calc(${config.space.S400} + ${toRem(52)})` }
: undefined;

const vListItemCount =
timelineSync.eventsLength === 0 &&
(!isReady || timelineSync.canPaginateBack || timelineSync.backwardStatus === 'loading')
Expand Down Expand Up @@ -1009,7 +1008,23 @@ export function RoomTimeline({
</VList>
</div>

{frontPaginationJSX}
{showBackPaginationSpinner && (
<TimelineFloat position="Top" style={timelineTopFloatLift}>
<Spinner variant="Secondary" size="400" />
</TimelineFloat>
)}

{showFrontPaginationSpinner && (
<TimelineFloat position="Bottom" style={timelineBottomFloatLift}>
<Spinner variant="Secondary" size="400" />
</TimelineFloat>
)}

{frontPaginationJSX && (
<TimelineFloat position="Bottom" style={timelineBottomFloatLift}>
{frontPaginationJSX}
</TimelineFloat>
)}

{!atBottomState && isReady && (
<TimelineFloat position="Bottom">
Expand Down
Loading