Skip to content

add per user voice activity ring indicators - #1749

Open
TomOdellSheetMusic wants to merge 2 commits into
SableClient:devfrom
TomOdellSheetMusic:per-user-voice-activity
Open

add per user voice activity ring indicators#1749
TomOdellSheetMusic wants to merge 2 commits into
SableClient:devfrom
TomOdellSheetMusic:per-user-voice-activity

Conversation

@TomOdellSheetMusic

@TomOdellSheetMusic TomOdellSheetMusic commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

Relies on SableClient/SableCall#21 !
This PR adds two more indicators as to who is talking in a call. In a room, it will show green rings around the speaking member's avatars in the room navigation and the bottom status bar. The bottom status bar also already had a written indicator that seems to not have worked before (or at I least I don't see it on the nightly desktop builds). In a 1:1 call, both bottom status bar indicators are shown.

Fixes SableClient/SableCall#9
UserRingSpeaking

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@eleboucher eleboucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please don't remove the ai part of the pr description please and fill it if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose Voice activity to the host.

2 participants