fix: prevent parsing electron and argument options as files #969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve command-line argument options parse with minimist.
This condition don't take into consideration
.electron-wrapped
or any other arbitrary named electron executable.This condition don't take into consideration argument options, like
--no-sandbox
.Instead of checking if a wrapper was run, it checks if an AppImage was run. The linux AppImage runs like this:
/path/to/sabaki-v0.52.2-linux-x64.AppImage/sabaki
. Note that the filename, sabaki, is hardcoded and cannot be changed. If it isn't an AppImage then it must be a wrapper and runs like this:/path/to/electron /path/to/app.asar
.Refs: #954