Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update endowed positions dataset #469

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

wmui51
Copy link
Collaborator

@wmui51 wmui51 commented Jan 17, 2025

READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • Update endowed positions dataset.

Review By (Date)

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. check, dev site to make sure site did not break, and also check that /endowed-positions is working.
  2. stakeholders will review data on dev page

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@forrestglick
Copy link
Collaborator

@wmui51 PR looks good. One small change – please change the "Last updated" at the bottom of the page(s) to January 17, 2025. Note the 2025. Thanks!

@wmui51
Copy link
Collaborator Author

wmui51 commented Jan 17, 2025

@forrestglick good catch, i have updated the footer.

Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like @forrestglick has reviewed and approved. I'm going to approve this. Will merge and cut a release tomorrow (Friday) 😄

@sherakama
Copy link
Member

Thanks all.

@forrestglick
Copy link
Collaborator

Thanks for the review/approval. It's looking good. Please push to Dev, and I'll have the client review before we push to Prod.

@yvonnetangsu yvonnetangsu merged commit e65d289 into dev Jan 17, 2025
5 checks passed
@yvonnetangsu yvonnetangsu deleted the feat/endowed-positions-dataset-011625 branch January 17, 2025 17:37
@yvonnetangsu
Copy link
Member

@forrestglick Merged to dev - should be ready in a couple minutes 😄

@forrestglick
Copy link
Collaborator

Client has approved the update. @yvonnetangsu Please push to Prod when you have the chance. Thanks!

@yvonnetangsu yvonnetangsu mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants