fix(duckdb): partition initial DuckLake writes - #5942
Open
anxkhn wants to merge 1 commit into
Open
Conversation
Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5742.
For partitioned DuckLake tables created from a query, create the table schema without writing data, apply the partition specification, and then insert the initial rows. This ensures the first DuckLake data files are physically partitioned, including for unannotated SQL models and fully qualified DuckLake targets.
Test Plan
uv run make styleuv run pytest -o addopts='' tests/core/engine_adapter/test_duckdb.py -q(13 passed)uv run make fast-test(2582 passed, 4 skipped; 6 unrelated MSSQL/Fabric tests failed because localpyodbccannot load the missingunixODBClibrary)Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO