Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c14 deBarrosDamgaard2018 #1357

Merged
merged 10 commits into from
Feb 7, 2025
Merged

c14 deBarrosDamgaard2018 #1357

merged 10 commits into from
Feb 7, 2025

Conversation

KaHea-21
Copy link
Contributor

@KaHea-21 KaHea-21 commented Feb 7, 2025

Pull Request

C14 date for deBarrosDamgaard added.
Comment: Extended Data Fig. 9 reports a date outside of the 1-sigma range in the SI (AD 186)

This PR is for a

For the following list(s):

  • ancientmetagenome-environmental (README)
  • ancientmetagenome-hostassociated (README)
  • ancientsinglegenome-hostassociated (README)

This is to close

PR Workflow

  1. Open this PR with sample metadata on the samples metadata sheet (:tada: you're already here!)
  2. Wait for checks for sample metdata to pass
  3. (If checks fail) make corrections, and push changes to this branch (no need to open a new PR!)
  4. (Once passed) comment on this PR @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! (may take a minute or so to get the comment with the file)
  5. Fill in the template, and verify autofilled data correct!
  6. Once filled in, append(!) the new rows from the TEMPLATE file to the end of the corresponding library metadata file, and update this PR
  7. Wait for checks for library metadata to pass
  8. Request review!

Pre-review checklist (new publications)

  • Publication is published
    • Preprints currently not accepted?
  • Checked the publication is not already in the database?
  • Checked samples in this publication are not previously published data?
    • Newly re-sequenced metagenomes are OK!
  • Samples are shotgun metagenomes and not amplicon data
    • Note: hostassociated-singlegenome may also contain whole-genome enriched data
  • Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
  • Once sample table validation completed Library metadata has been added
    • Use @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! May take a minute or so to get the comment with the file
    • Fill in template, and verify autofill data correct!
    • Once filled in, append(!) the new rows to the end of the corresponding library metadata file
  • Changelog is updated to include the publication under 'Added'?

@marcel-keller marcel-keller self-assigned this Feb 7, 2025
Corrected entries for deBarrosDamgaard2018
Corrected entries for deBarrosDamgaard20218 (2)
C14 deBarrosDamgaard2018
Copy link
Member

@aidaanva aidaanva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the changes are done it is ready to be merged

CHANGELOG.md Outdated Show resolved Hide resolved
@@ -4,3 +4,6 @@ AndradesValtuena2017 2017 10.1016/j.cub.2017.10.025 6Post PRJEB19335 ERS1892066
Spyrou2018 2018 10.1038/s41467-018-04550-9 RT5 PRJEB24296 ERS2106903 TRUE TRUE DNE FALSE supplement text 1 10.1038/s41467-018-04550-9 TRUE MAMS 29430 AMS NR NR tooth 3517 27 -99999 -99999 -99999 -99999 TRUE NR NR NR NR NR 3868 3704 3789 cal BP 2 FALSE DNE DNE NA NA NA NA
Spyrou2018 2018 10.1038/s41467-018-04550-9 RT6 PRJEB24296 ERS2106904 TRUE TRUE DNE FALSE supplement text 1 10.1038/s41467-018-04550-9 TRUE MAMS 29431 AMS NR NR tooth 3499 25 -99999 -99999 -99999 -99999 TRUE NR NR NR NR NR 3842 3696 -99999 cal BP 2 FALSE DNE DNE NA NA NA NA
Warinner2014 2014 10.1038/ng.2906 G12 PRJNA216965 SRS473747,SRS473746,SRS473748,SRS473749,SRS473750 FALSE FALSE DNE DNE DNE DNE DNE DNE DNE DNE NA DNE DNE DNE unknown NA NA NA NA NA NA DNE DNE DNE DNE DNE DNE NA NA NA DNE NA DNE DNE DNE NA NA NA NA
deBarrosDamgaard2018 2018 10.1038/s41586-018-0094-2 DA101 PRJEB25891 ERS2367268 TRUE TRUE DNE FALSE supplement table 1 10.1038/s41586-018-0094-2 TRUE UBA 31214 AMS TRUE Collagen (ultrafiltered) unknown 1783 29 -16.3 -99999 12.6 3.15 TRUE IntCal13 Calib DNE NR 10.1017/S0033822200013904 261 214 NA cal AD 1 FALSE FALSE DNE NA NA NA NA
deBarrosDamgaard2018 2018 10.1038/s41586-018-0094-2 DA147 PRJEB25891 ERS2367269 FALSE FALSE DNE DNE DNE DNE DNE DNE DNE NA DNE DNE DNE unknown NA NA NA NA NA NA TRUE DNE DNE DNE DNE DNE NA NA NA DNE NA DNE DNE DNE NA NA NA NA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The authors report for this individual an archaeological date based on the culture: sixth–ninth century AD. I suggest we add it in the archaeological_historical_date column

Copy link

github-actions bot commented Feb 7, 2025

amdirt, version 1.6.5

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

Dates

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_dates.tsv is valid

@aidaanva aidaanva merged commit deab42c into master Feb 7, 2025
1 check passed
@aidaanva aidaanva deleted the C14-deBarrosDamgaard2018 branch February 7, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants