Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantics of empty blocks #19

Merged
merged 7 commits into from
Aug 29, 2020
Merged

Conversation

smarr
Copy link
Member

@smarr smarr commented Aug 24, 2020

This PR does make sure that empty blocks evaluate to nil.
On the way of getting there, it does a bit more cleanup:

  • make method generation context less mutable
  • add Parser.toString()
  • replace Vector in MethodGenerationContext with an ArrayList (don't need the synchronized)

@sophie-kaleba could you take a look at this one and review/approach it?
I'd assume grSOM will need this update, too.

This addresses SOM-st/SOM#36 and SOM-st/SOM#54.

@smarr smarr force-pushed the uninitialized-locals branch from 5d1ca8b to ea9f341 Compare August 25, 2020 11:22
Copy link
Collaborator

@sophie-kaleba sophie-kaleba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I'll add it to the pile of things I have to update in grSOM!

@smarr smarr merged commit 41846b0 into SOM-st:master Aug 29, 2020
@smarr smarr deleted the uninitialized-locals branch August 29, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants