Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace InvokeOnCache with use of DSL, and remove unused file #112

Merged
merged 2 commits into from
Dec 5, 2021
Merged

Replace InvokeOnCache with use of DSL, and remove unused file #112

merged 2 commits into from
Dec 5, 2021

Conversation

smarr
Copy link
Member

@smarr smarr commented Dec 5, 2021

@OctaveLarose, that's another easy one. Here the DSL seems to be beneficial in terms of code size reduction. Performance is still to be determined.

@smarr
Copy link
Member Author

smarr commented Dec 5, 2021

SOM-st/SOM#85 adds a basic test for this.
Though, looks like no other SOM even implements the primitive, oops...
So, will be a while before the tests are merged.
Will merge the PR anyway since the tests pass locally.

@smarr smarr merged commit 0a87eb8 into SOM-st:master Dec 5, 2021
@smarr smarr deleted the invoke-on branch December 5, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smarr