Add RETURN_SELF and optimize the DUP, POP_X, POP sequences #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combines PUSH_SELF+RETURN_LOCAL into a single bytecode, and sometime omits POP. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for this PR is to simplify bytecode sequences, remove a bit of cruft, to make it easier to recognize setters as trivial methods.
Though, this also gives a bit of a performance benefit, especially on micro benchmarks.
The PR also adds more of the unusual infrastructure we have to deal with bytecodes.
https://rebench.dev/SOMpp/compare/dc902fb54bd693ccc02f3cbd4f1cedc2ae802649..e33d58323d14ab2e3f5befc7c37218df9c3cbab1
Run time: median -1% (min. -46%, max. 14%)