Add support for LexicalScopes, Variables, and SourceCoordinates #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation of adding inlining. - use %.*s to limit the number of characters used in snprintf - make sure we always have a lexical scope, also for bootstrap frame Signed-off-by: Stefan Marr <[email protected]>
- this also avoids a lot of symbol creation - LexicalScopes are owned by VMMethod Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
|
I think the change is performance neutral: https://rebench.dev/SOMpp/compare/eca9b14ecff2051a5a39ee434eac904f04538972..ed8667ea678d77bde970e95fb83b904506f8ba6c I hope the performance effects visible are within the error margins. Not clear though. |
smarr
added a commit
that referenced
this pull request
Aug 1, 2024
This PR uses the infrastructure introduced previously in #32 to implement bytecode-level inlining in the same style as in TruffleSOM and PySOM. One improvement here is that we remove blocks from the literals, too, which leads in the tests to use more use of the specialized bytecodes. Generally, the new introduced bytecodes for jumps have all the same length, and exist in two variants, one that only uses one byte, i.e., shorted jumps, and the other that uses both. This also introduces keeping track of the last 4 bytecodes, which is useful for other optimizations later on, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding infrastructure to enable inlining on the bytecode level.
It introduces the notion of LexicalScopes, Variables, and SourceCoordinates.
LexicalScopes encode the info needed about the program structure/relationship between methods and blocks.
Variables encode the location of arguments and locals, in terms of SourceCoordinates.
This PR also reduces the number of symbols that need to be created by relying on std::strings for aspects that won't be exposed to the language level.
There's also a bit extra support here for debugging the GCs and interactive debugging, for instance printing/dumping of methods.
This is split out as a PR to be able to assess the performance impact.